Handle missing __DEFAULT__ branch gracefully #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
chantra
reviewed
May 14, 2024
kernel_patches_daemon/github_sync.py
Outdated
Comment on lines
122
to
125
| try: | ||
| mapped_branches = self.tag_to_branch_mapping["__DEFAULT__"] | ||
| except KeyError: | ||
| return [] |
There was a problem hiding this comment.
You can use dict.get(key, default), e.g:
mapped_branches = self.tag_to_branch_mapping.get("DEFAULT", [])
There are cases that we don't want to do PR for patches without a mapped branch. IOW, there is no "__DEFAULT__" branch. Handle such cases gracefully. Signed-off-by: Song Liu <[email protected]>
liu-song-6
force-pushed
the
no-default-branch
branch
from
1e732a2 to
725834c
Compare
|
@chantra has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases that we don't want to do PR for patches without a mapped branch. IOW, there is no "DEFAULT" branch. Handle such cases gracefully.