Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugify branch names in patchwork report #39

Closed
wants to merge 1 commit into from

Conversation

liu-song-6
Copy link
Contributor

patchwork only accepts ASCII letters, numbers, underscores or hyphens in slugs. Let's replace "." in the branch name, for example md-6.10, with "_", i.e. md-6_10.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@chantra
Copy link
Contributor

chantra commented May 14, 2024

Thanks.

Do you mind putting this in a function and re-using the function in those 2 places? There is probably more char that we need to properly replace that we may find out later.
With the reference to the patchwork 's https://github.com/getpatchwork/patchwork/blob/2aa4742ec88be4cd07f569805d22a35c08a08f40/releasenotes/notes/slugify-check-context-dc586f204b5058a7.yaml ?

@facebook-github-bot
Copy link
Contributor

@liu-song-6 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@chantra has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@liu-song-6 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@liu-song-6 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

patchwork only accepts ASCII letters, numbers, underscores or hyphens in
slugs. Let's replace "." in the branch name, for example md-6.10, with
"_", i.e. md-6_10.

Signed-off-by: Song Liu <[email protected]>
@facebook-github-bot
Copy link
Contributor

@liu-song-6 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@liu-song-6 merged this pull request in 454b980.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants