Fix open source unit tests #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58969097 |
|
This pull request was exported from Phabricator. Differential Revision: D58969097 |
danobi
pushed a commit
to danobi/kernel-patches-daemon
that referenced
this pull request
Jun 24, 2024
Summary: Pull Request resolved: facebookincubator#43 We were adding an extra "fixtures" directory for fixture paths in TARGETS. Pathing doesn't work like that for standard python imports, so remove this extra level. Also consolidate the two read_fixture() definitions into a single place Differential Revision: D58969097
|
This pull request was exported from Phabricator. Differential Revision: D58969097 |
danobi
pushed a commit
to danobi/kernel-patches-daemon
that referenced
this pull request
Jun 25, 2024
Summary: Pull Request resolved: facebookincubator#43 We were adding an extra "fixtures" directory for fixture paths in TARGETS. Pathing doesn't work like that for standard python imports, so remove this extra level. Also consolidate the two read_fixture() definitions into a single place Differential Revision: D58969097
Summary: Pull Request resolved: facebookincubator#43 We were adding an extra "fixtures" directory for fixture paths in TARGETS. Pathing doesn't work like that for standard python imports, so remove this extra level. Also consolidate the two read_fixture() definitions into a single place Differential Revision: D58969097
|
This pull request was exported from Phabricator. Differential Revision: D58969097 |
|
This pull request has been merged in 5714ecf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We were adding an extra "fixtures" directory for fixture paths in TARGETS. Pathing doesn't work like that for standard python imports, so remove this extra level. Also consolidate the two read_fixture() definitions into a single place
Differential Revision: D58969097