Loosen certifi version requirements #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certifi package has a "vulnerability" [0], asking us to update. Dependabot should take care of that, except it didn't: > updater | 2024/07/05 <job_852060501> Checking if certifi 2023.11.17 needs updating > proxy | 2024/07/05 GET https://pypi.org:443/simple/certifi/ > proxy | 2024/07/05 200 https://pypi.org:443/simple/certifi/ > updater | 2024/07/05 <job_852060501> Filtered out 2 yanked versions > updater | 2024/07/05 <job_852060501> Latest version is 2024.7.4 > updater | 2024/07/05 <job_852060501> Requirements to unlock update_not_possible > updater | 2024/07/05 <job_852060501> Requirements update strategy lockfile_only > updater | 2024/07/05 <job_852060501> No update possible for certifi 2023.11.17 I suspect that reason is that it interprets the version as a SemVer specification and 2023 -> 2024 would be a major bump and it won't do that given our strategy. Let's just use any version. [0] https://github.com/facebookincubator/kernel-patches-daemon/security/dependabot/23
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in d20dba4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certifi package has a "vulnerability" [0], asking us to update. Dependabot should take care of that, except it didn't:
I suspect that reason is that it interprets the version as a SemVer specification and 2023 -> 2024 would be a major bump and it won't do that given our strategy.
It appears none of our Python code is actually depending on this package, so let's just remove it.
[0] https://github.com/facebookincubator/kernel-patches-daemon/security/dependabot/23