build: Remove poetry.lock from source control #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had a bunch of PRs to tend to due to dependabot: https://github.com/facebookincubator/kernel-patches-daemon/pulls?q=is%3Apr++label%3Adependencies+ In most cases, those were only changing the depedency in the .lock file. We are not getting much value of shipping this file, and will be better off by getting rid of it and fixign the remotely possible breakage in the future vs dealing with those weekly. Signed-off-by: Manu Bretelle <[email protected]>
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
chantra
added a commit
to chantra/kernel-patches-daemon
that referenced
this pull request
Sep 11, 2024
With yarl 1.9.5 release, the tests would start failing. Changelog: https://yarl.aio-libs.org/en/latest/changes/#id26 TL;DR, the :0 would get eaten and the mock would not intercept the http calls. Tested this manually with 1.9.4 and 1.9.5. The next diff which is part of facebookincubator#59 will confirm I did not screw up. Signed-off-by: Manu Bretelle <[email protected]>
|
will need to rebase this on top of #60 to make the tests pass. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Summary: With yarl 1.9.5 release, the tests would start failing. Changelog: https://yarl.aio-libs.org/en/latest/changes/#id26 TL;DR, the :0 would get eaten and the mock would not intercept the http calls. Tested this manually with 1.9.4 and 1.9.5. The next diff which is part of #59 will confirm I did not screw up. Pull Request resolved: #60 Reviewed By: chantra Differential Revision: D62521426 fbshipit-source-id: 4f39e59a1a1fc5954376721117674dbf85370463
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in ff326f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a bunch of PRs to tend to due to dependabot: https://github.com/facebookincubator/kernel-patches-daemon/pulls?q=is%3Apr++label%3Adependencies+
In most cases, those were only changing the depedency in the .lock file. We are not getting much value of shipping this file, and will be better off by getting rid of it and fixign the remotely possible breakage in the future vs dealing with those weekly.