Remove lint warnings in ParquetReaderTest (#9760)

Summary: Pull Request resolved: #9760 Reviewed By: mbasmanova Differential Revision: D57162713 fbshipit-source-id: 5a19fdd0cc0917cfde5cd8fe7654bd79aac36523
facebookincubator · May 9, 2024 · 3e98d40 · 3e98d40
1 parent dceaff0
commit 3e98d40
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/velox/dwio/parquet/tests/reader/ParquetReaderTest.cpp b/velox/dwio/parquet/tests/reader/ParquetReaderTest.cpp
@@ -792,6 +792,7 @@ TEST_F(ParquetReaderTest, doubleFilters) {
 
   assertReadWithFilters(
       "sample.parquet", sampleSchema(), std::move(filters), expected);
+  filters.clear();
 
   // Test "b <= 10.0".
   filters.insert({"b", exec::lessThanOrEqualDouble(10.0)});
@@ -801,6 +802,7 @@ TEST_F(ParquetReaderTest, doubleFilters) {
   });
   assertReadWithFilters(
       "sample.parquet", sampleSchema(), std::move(filters), expected);
+  filters.clear();
 
   // Test "b between 10.0 and 14.0".
   filters.insert({"b", exec::betweenDouble(10.0, 14.0)});
@@ -810,6 +812,7 @@ TEST_F(ParquetReaderTest, doubleFilters) {
   });
   assertReadWithFilters(
       "sample.parquet", sampleSchema(), std::move(filters), expected);
+  filters.clear();
 
   // Test "b > 14.0".
   filters.insert({"b", exec::greaterThanDouble(14.0)});
@@ -819,6 +822,7 @@ TEST_F(ParquetReaderTest, doubleFilters) {
   });
   assertReadWithFilters(
       "sample.parquet", sampleSchema(), std::move(filters), expected);
+  filters.clear();
 
   // Test "b >= 14.0".
   filters.insert({"b", exec::greaterThanOrEqualDouble(14.0)});
@@ -828,6 +832,7 @@ TEST_F(ParquetReaderTest, doubleFilters) {
   });
   assertReadWithFilters(
       "sample.parquet", sampleSchema(), std::move(filters), expected);
+  filters.clear();
 }
 
 TEST_F(ParquetReaderTest, varcharFilters) {
@@ -846,6 +851,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
 
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name <= 'CANADA'".
   filters.insert({"name", exec::lessThanOrEqual("CANADA")});
@@ -856,6 +862,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name > UNITED KINGDOM".
   filters.insert({"name", exec::greaterThan("UNITED KINGDOM")});
@@ -866,6 +873,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name >= 'UNITED KINGDOM'".
   filters.insert({"name", exec::greaterThanOrEqual("UNITED KINGDOM")});
@@ -877,6 +885,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name = 'CANADA'".
   filters.insert({"name", exec::equal("CANADA")});
@@ -887,6 +896,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name IN ('CANADA', 'UNITED KINGDOM')".
   filters.insert({"name", exec::in({std::string("CANADA"), "UNITED KINGDOM"})});
@@ -897,6 +907,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 
   // Test "name IN ('UNITED STATES', 'CANADA', 'INDIA', 'RUSSIA')".
   filters.insert(
@@ -910,6 +921,7 @@ TEST_F(ParquetReaderTest, varcharFilters) {
   });
   assertReadWithFilters(
       "nation.parquet", rowType, std::move(filters), expected);
+  filters.clear();
 }
 
 TEST_F(ParquetReaderTest, readDifferentEncodingsWithFilter) {