Skip to content

Commit

Permalink
fix(hdfs): Dangling-gsl error in HdfsFileSystemTest.cpp (#12319)
Browse files Browse the repository at this point in the history
Summary:
https://github.com/facebookincubator/velox/actions/runs/13277154504/job/37068749183

Pull Request resolved: #12319

Reviewed By: kevinwilfong

Differential Revision: D69605849

Pulled By: kgpai

fbshipit-source-id: 7aa11a25be50868b62e02d320b0c4d10000d5313
  • Loading branch information
majetideepak authored and facebook-github-bot committed Feb 13, 2025
1 parent d8cac2f commit 8524313
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ void readData(ReadFile* readFile) {
delete[] buffer3;
ASSERT_EQ(readFile->size(), 15 + kOneMB);
char buffer4[10];
const std::string_view arf = readFile->pread(5, 10, &buffer4);
const std::string_view zarf = readFile->pread(kOneMB, 15);
auto arf = readFile->pread(5, 10, &buffer4);
auto zarf = readFile->pread(kOneMB, 15);
auto buf = std::make_unique<char[]>(8);
const std::string_view warf = readFile->pread(4, 8, buf.get());
auto warf = readFile->pread(4, 8, buf.get());
const std::string_view warfFromBuf(buf.get(), 8);
ASSERT_EQ(arf, "bbbbbccccc");
ASSERT_EQ(zarf, "ccccccccccddddd");
Expand Down

0 comments on commit 8524313

Please sign in to comment.