Skip to content

Commit

Permalink
fix: "Memory" is misspelt (#12222)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: #12222

Reviewed By: DanielHunte

Differential Revision: D69060390

Pulled By: bikramSingh91

fbshipit-source-id: 48fcc90e3a988c9f602221d13d81961195c1f98e
  • Loading branch information
aditi-pandit authored and facebook-github-bot committed Feb 3, 2025
1 parent f1dec31 commit e484679
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion velox/common/memory/SharedArbitrator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ SharedArbitrator::SharedArbitrator(const Config& config)
std::thread::hardware_concurrency() * memoryReclaimThreadsHwMultiplier_);
memoryReclaimExecutor_ = std::make_unique<folly::CPUThreadPoolExecutor>(
numReclaimThreads,
std::make_shared<folly::NamedThreadFactory>("MeomryReclaim"));
std::make_shared<folly::NamedThreadFactory>("MemoryReclaim"));
VELOX_MEM_LOG(INFO) << "Start memory reclaim executor with "
<< numReclaimThreads << " threads";

Expand Down
4 changes: 2 additions & 2 deletions velox/common/memory/tests/MemoryArbitratorTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ TEST_F(MemoryReclaimerTest, orderedReclaim) {
uint64_t reclaimableBytes{0};
// 'expectedReclaimableUnits' is the expected allocation unit per each child
// pool after each round of memory reclaim. And we expect the memory reclaimer
// always reclaim from the child with most meomry usage.
// always reclaim from the child with most memory usage.
auto verify = [&](const std::vector<int>& expectedReclaimableUnits) {
root->reclaimer()->reclaimableBytes(*root, reclaimableBytes);
ASSERT_EQ(reclaimableBytes, totalAllocUnits * allocUnitBytes) << "total";
Expand Down Expand Up @@ -944,7 +944,7 @@ TEST_F(MemoryReclaimerTest, skipNonReclaimableChild) {
uint64_t reclaimableBytes{0};
// 'expectedReclaimableUnits' is the expected allocation unit per each child
// pool after each round of memory reclaim. And we expect the memory reclaimer
// always reclaim from the child with most meomry usage.
// always reclaim from the child with most memory usage.
auto verify = [&](const std::vector<int>& expectedReclaimableUnits) {
uint64_t expectedTotalReclaimableBytes{0};
for (int i = 0; i < numChildren; ++i) {
Expand Down
2 changes: 1 addition & 1 deletion velox/exec/tests/ScaledScanControllerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ TEST_F(ScaledScanControllerTest, basic) {
3},

// Test case that we can only scale up to six drivers as hit the query
// meomry usage ratio limit.
// memory usage ratio limit.
{256 << 20,
0.5,
64 << 20,
Expand Down

0 comments on commit e484679

Please sign in to comment.