feat: Add Spark array_append function #12043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
rui-mo
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Thanks for your contribution. We can simply register this Presto function to Spark if their semantics are exactly the same. If any change on the implementation is needed for the reuse, we could move it to the 'velox/functions/lib' folder and make the necessary changes. Please also add documentation for the new registered Spark function.
leoluan2009
force-pushed
the
array_append
branch
from
4263b6c to
dbdc5ab
Compare
|
@rui-mo Updated as your suggestion, can you review again? |
leoluan2009
force-pushed
the
array_append
branch
from
dbdc5ab to
5ec415e
Compare
leoluan2009
force-pushed
the
array_append
branch
from
5ec415e to
f404b3f
Compare
rui-mo
reviewed
Jan 24, 2025
| @@ -15,6 +15,12 @@ Array Functions | |||
|
|
|||
| SELECT array(1, 2, 3); -- [1,2,3] | |||
|
|
|||
| .. spark:function:: array_append(array(E), value) -> array(E) | |||
|
|
|||
| Add the element at the end of the array passed as first argument. :: | |||
There was a problem hiding this comment.
Perhaps also document the behavior when input array or value is null.
| FOLLY_ALWAYS_INLINE bool callNullable( | ||
| out_type<Array<Generic<T1>>>& out, | ||
| const arg_type<Array<Generic<T1>>>* array, | ||
| const arg_type<Generic<T1>>* element) { |
There was a problem hiding this comment.
Do we have test for element being null?
rui-mo
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Spark array_append function