feat: Support dynamic filters for Right Join #12057
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
@xiaodouchen Thank you for adding this optimization. Looks good to me.
Would you update the documentation at https://facebookincubator.github.io/velox/develop/joins.html#dynamic-filter-pushdown ? It currently says "Dynamic filter pushdown optimization is enabled for inner, left semi, and right semi joins."
Would you also check if we get Fuzzer coverage for this new code flow. CC: @kagamiori
xiaodouchen
force-pushed
the
xiaodou_right_support_rtf
branch
from
6b6fb55 to
2943bba
Compare
|
@mbasmanova
|
| Dynamic filter pushdown optimization is enabled for inner, left semi, and | ||
| right semi joins. | ||
| Dynamic filter pushdown optimization is enabled for inner, left semi, right semi | ||
| and right joins. |
There was a problem hiding this comment.
Is this supported for left join as well? If so, please, update the sentence.
There was a problem hiding this comment.
No, it can not be supported for left join. Because left join needs to output rows that do not match, if the dynamic filter is pushed down to the scan, it would filter out these rows.
There was a problem hiding this comment.
Good point. Thank you for clarifying.
Nice. Would you mention this in the PR description? |
@mbasmanova Yes, done. |
mbasmanova
added
the
ready-to-merge
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 76bb570. |
Support dynamic filters for right join and this new code flow has been
covered in Join Fuzzer. Note: Right join can not be completely replaced
with a pushed down filter when build side has no dependent columns.