feat(build): Print out build metrics #12142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kgpai
force-pushed
the
print_build_stats
branch
3 times, most recently
from
ea37768 to
f1bea64
Compare
kgpai
force-pushed
the
print_build_stats
branch
from
f1bea64 to
6be2180
Compare
kgpai
commented
Jan 22, 2025
| ) | ||
| make '${{ matrix.type }}' | ||
| echo "CMake Flags: ${EXTRA_CMAKE_FLAGS[*]}" | ||
| make '${{ matrix.type }}' EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS[*]}" |
There was a problem hiding this comment.
Neat , did not know this trick.
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
assignUser
approved these changes
Jan 22, 2025
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the name of the build metrics job to also include type of linking and also print out sizes as part of the logs.