docs: Update Presto functions coverage map #12195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
| :func:`filter` :func:`parse_datetime` :func:`zip_with` | ||
| :func:`find_first` :func:`pi` | ||
| ====================================== ====================================== ====================================== == ====================================== == ====================================== | ||
| ======================================== ======================================== ======================================== == ======================================== == ======================================== |
There was a problem hiding this comment.
@pramodsatya : Can you generate the doc and check the end result. The viewer is showing a strange part with an entry for not
and another place with function 'in' as well
There was a problem hiding this comment.
Thanks for pointing it out @aditi-pandit, the links for not and in appear to be missing in the current prestosql coverage map doc as well: https://facebookincubator.github.io/velox/functions.html .
There was a problem hiding this comment.
@pramodsatya : Lets debug why they are not present. But the changes here are sufficient for this PR.
aditi-pandit
approved these changes
Jan 28, 2025
majetideepak
approved these changes
Feb 7, 2025
|
@pramodsatya can you rebase with the latest main? Thanks. |
pramodsatya
force-pushed
the
presto_cov_map
branch
from
bef1638 to
e127fdb
Compare
|
Thanks @majetideepak, rebased on latest main. |
majetideepak
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the complete list of Presto scalar and aggregate functions using output from
Presto
SHOW FUNCTIONS.Re-generated coverage maps with instructions from
velox/functions/prestosql/coverage/README.md.