fix: Update the Description of map_top_n #12216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D68913230 |
zacw7
approved these changes
Jan 30, 2025
duxiao1212
changed the title
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
Jan 30, 2025
Summary: Update the description of map_top_n map function **map_top_n** returns a new map containing only the top N elements, sorted in descending order by value. In cases where values are tied, the function sorts the tied elements in lexicographical descending order by key. Since both 'a' and 'c' have null values, 'c' is included in the top 2 results along with 'b', Reviewed By: zacw7 Differential Revision: D68913230
duxiao1212
force-pushed
the
export-D68913230
branch
from
7be2f9c to
563afee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68913230 |
Summary: Update the description of map_top_n map function **map_top_n** returns a new map containing only the top N elements, sorted in descending order by value. In cases where values are tied, the function sorts the tied elements in lexicographical descending order by key. Since both 'a' and 'c' have null values, 'c' is included in the top 2 results along with 'b', Reviewed By: zacw7 Differential Revision: D68913230
duxiao1212
force-pushed
the
export-D68913230
branch
from
563afee to
15c6343
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68913230 |
|
This pull request has been merged in 832583d. |
ArnavBalyan
pushed a commit
to ArnavBalyan/velox
that referenced
this pull request
Jan 31, 2025
Summary: Pull Request resolved: facebookincubator#12216 Update the description of map_top_n map function **map_top_n** returns a new map containing only the top N elements, sorted in descending order by value. In cases where values are tied, the function sorts the tied elements in lexicographical descending order by key. Since both 'a' and 'c' have null values, 'c' is included in the top 2 results along with 'b', Reviewed By: zacw7 Differential Revision: D68913230 fbshipit-source-id: 7d0483d28e2f7eada5e1dcb7e0bd000857f831ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the description of map_top_n
map function map_top_n returns a new map containing only the top N elements, sorted in descending order by value. In cases where values are tied, the function sorts the tied elements in lexicographical descending order by key.
Since both 'a' and 'c' have null values, 'c' is included in the top 2 results along with 'b',
Differential Revision: D68913230