fix(s3): Allow custom identity function #12217
Open
+66
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
force-pushed
the
fix-s3-identity
branch
3 times, most recently
from
8306003 to
049a4a6
Compare
majetideepak
force-pushed
the
fix-s3-identity
branch
from
049a4a6 to
be1f77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today S3FileSystem caches the instances based on the endpoint value.
The endpoint value is not a sufficient key in practice. Usually, the credentials are
per bucket. Presto uses the bucket name as a key as well.
This PR changes the default key to use endpoint + bucket name.
Users can optionally provide a function to define the key
for caching the instances to allow customization.