feat: Support cancellation in HashProbe::getOutput [3/n] #12237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68997164 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Feb 3, 2025
…ubator#12237) Summary: Hashprobe::getOutput can take a long time to run for degenerate query shapes. Differential Revision: D68997164
yuandagits
force-pushed
the
export-D68997164
branch
from
5993475 to
50e062f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68997164 |
Yuhta
approved these changes
Feb 3, 2025
…ubator#12237) Summary: Hashprobe::getOutput can take a long time to run for degenerate query shapes. Reviewed By: Yuhta Differential Revision: D68997164
yuandagits
force-pushed
the
export-D68997164
branch
from
50e062f to
d560915
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68997164 |
|
This pull request has been merged in 95a5a4f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Hashprobe::getOutput can take a long time to run for degenerate query shapes.
Differential Revision: D68997164