fix(fuzzer): Filter keys from both join sides instead of just one #12246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69079267 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Feb 3, 2025
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
DanielHunte
force-pushed
the
export-D69079267
branch
from
cd22db9 to
92792ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69079267 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Feb 4, 2025
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Feb 4, 2025
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
DanielHunte
force-pushed
the
export-D69079267
branch
from
92792ff to
d206e52
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69079267 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Feb 4, 2025
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Feb 4, 2025
…cebookincubator#12246) Summary: Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator. The fix to support this would be disabling filter pushdown when filtering only one side of a join. Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans. For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely. Differential Revision: D69079267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Joins operators with filters on one side are not currently supported in Velox. It is expected that such a filter would be pushed down to the table scan and therefore not show up in the join operator.
The fix to support this would be disabling filter pushdown when filtering only one side of a join.
Alternatively, filters within join operators can be checked to ensure that the filter contains keys from both sides, else throw an exception. This change will require testing in production to see if Presto produces such plans.
For now, changing the join fuzzer filter creation to include keys from both sides will avoid this type of failure completely.
Differential Revision: D69079267