fix: Remove support for evaluating sub-optimial filters in joins #12251
+54
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This enables the hash join operator to throw an error when a filter is applied exclusively to columns from one side of the join. This validation ensures the detection of suboptimal plans, where filters are evaluated at the join operator instead of being pushed to the upstream scan node of the respective join side for optimization. Also adds a private API to ensure an internal state variable which is a buffer is unique before any mutations are applied to it. Differential Revision: D69085909
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69085909 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Feb 4, 2025
| // Note: Use this method close to the block that modifies the buffer to ensure | ||
| // mutability does not change in-between. | ||
| vector_size_t* getRawMutableOuputRowMapping() { | ||
| VELOX_CHECK(outputRowMapping_->isMutable()); |
There was a problem hiding this comment.
This is check is failing because we keep 2 references: One in outputRowMapping_ and another in filter input. Maybe loose the condition a little bit? The case that would cause problem would have 3 references: outputRowMapping_, filter input, filter output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This enables the hash join operator to throw an error when a filter is applied exclusively
to columns from one side of the join. This validation ensures the detection of
suboptimal plans, where filters are evaluated at the join operator instead of being
pushed to the upstream scan node of the respective join side for optimization.
Also adds a private API to ensure an internal state variable which is a buffer is
unique before any mutations are applied to it.
Differential Revision: D69085909