-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add API to return function signatures by name #12289
Conversation
This pull request was exported from Phabricator. Differential Revision: D69368657 |
✅ Deploy Preview for meta-velox canceled.
|
…r#12289) Summary: Add velox::getFunctionSignatures(name) API to get a list of function signatures by name. Use this API to optimize lambda function resolution logic. Differential Revision: D69368657
f801149
to
c26e1d6
Compare
This pull request was exported from Phabricator. Differential Revision: D69368657 |
…r#12289) Summary: Add velox::getFunctionSignatures(name) API to get a list of function signatures by name. Use this API to optimize lambda function resolution logic. Differential Revision: D69368657
c26e1d6
to
73a7ae9
Compare
This pull request was exported from Phabricator. Differential Revision: D69368657 |
CI failure is due to a flaky test #6984 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @mbasmanova
This pull request has been merged in b673c2d. |
Summary:
Add velox::getFunctionSignatures(name) API to get a list of function signatures by name.
Use this API to optimize lambda function resolution logic.
Differential Revision: D69368657