fix: Revert Optimize PrestoBatchVectorSerializer changes #12291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2025 15:28
Summary: This diff reverts D68044877 S488022 Differential Revision: D69377513
Summary: Revert facebookincubator#12060 facebookincubator#12072 due to suspected issues it introduced in the PrestoBatchVectorSerializer (crashes coming from the Allocations in the StreamArena). Differential Revision: D69377518
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69377518 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request has been merged in 35711b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revert
#12060
#12072
due to suspected issues it introduced in the PrestoBatchVectorSerializer (crashes coming from
the Allocations in the StreamArena).
Differential Revision: D69377518