Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPU kernel breakdown by user annotation range #213

Closed
wants to merge 6 commits into from

Conversation

briancoutinho
Copy link
Contributor

@briancoutinho briancoutinho commented Jan 29, 2025

What does this PR do?

Adds a trace analysis method to get GPU kernel breakdown by user annotation range.
Addresses #206 #180

Example notebook


Screenshot 2025-01-30 at 6 20 53 PM
Screenshot 2025-01-30 at 6 20 46 PM

Tests

Testplan:

pytest tests/test_trace_analysis.py -k test_get_gpu_kernels_with_user_annotations
pytest tests/test_trace_utils.py -k test_shorten_name

Before submitting

  • [y] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • [y] Did you write any new necessary tests?
    • N/A
  • [y] Did you make sure to update the docs?
    • N/A
  • [y] Did you update the changelog?
    • N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025
@briancoutinho briancoutinho force-pushed the 0127_add_gpu_kernel_user_anno branch from 6fd44d9 to 19af530 Compare January 31, 2025 02:12
@briancoutinho briancoutinho marked this pull request as ready for review January 31, 2025 21:14
@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@briancoutinho briancoutinho force-pushed the 0127_add_gpu_kernel_user_anno branch from 19af530 to 0cc937c Compare February 3, 2025 19:32
@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho merged this pull request in 8eb1e0c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants