Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of data processing #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akharche
Copy link

Minor changes to improve performance of data processing stage:

  1. np.fromiter creates an array directly from iterator returned from map
  2. np.unique reduces number of iterations over categorical columns (depends on the number of unique categories in each column)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2021
@tim5go
Copy link

tim5go commented Jan 4, 2022

@akharche
May I know if you test it on Criteo Terabyte dataset?
It looks like it is slower rather faster after adopting your changes.

@akharche
Copy link
Author

@tim5go
Yes, we tested on the subset (~50GB) of Criteo Terabyte dataset. These changes gave 14% performance improvements of the data processing part in our case. But the experiments were made a year ago.

@tim5go
Copy link

tim5go commented Jan 26, 2022

@akharche
I re-run your enhancements on my custom dataset.
It was not the case.
I'm not sure why, but it was running forever and never proceed to the next data-processing stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants