Make sharding plan explicit in torchrec dlrm example #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous code, DistributedModelParallel was responsible for creating
sharding plans for DLRM. It relied on hard-coded constants to create the
topology for planning (e.g. batch size=512, HBM_CAP=32GB and so on).
This was problematic because it did not reflect the true system
topology. Also, testing different constraints for sharding types and
compute kernels were inconvenient in the previous code.
Thus, we explicitly created sharding plans for DLRM before DMP and
provided some simple options to make life easier.