-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iss7 #12
Conversation
Should this really be in plotting? Maybe an own submodule like |
good question. |
Yeah, i think because |
__bias_to_trigger_patch_map = None | ||
|
||
def bias_to_trigger_patch_map(): | ||
global __bias_to_trigger_patch_map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this kind of caching? Better use from functools import lru_cache
and @lru_cache
maybe we can merge this now. |
|
||
@lru_cache(maxsize=1) | ||
def bias_to_trigger_patch_map(): | ||
mapfile = res.resource_filename("fact", "resources/FACTmap111030.txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not have to load the file again, it is in the namespace of this submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this speak against merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah now I understand. Thanks ,... I'll use that
please don't merge yet I need the credentials ... I would like to include them into this package now... |
Ok |
okay done |
trying to solve issue #7