-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deterministic layout #592
Deterministic layout #592
Conversation
(cherry picked from commit a0a03e4)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
============================================
- Coverage 51.55% 51.38% -0.17%
+ Complexity 6438 6413 -25
============================================
Files 367 372 +5
Lines 37553 37555 +2
Branches 6155 6123 -32
============================================
- Hits 19360 19299 -61
- Misses 16915 16981 +66
+ Partials 1278 1275 -3
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work @ennerf, this greatly reduces the rendering inconsistencies between charts and axes and also reduces the complexity which made it increasingly harder to follow up on issues concerning layout and axes.
The most important improvements are demonstrated in: #579 (comment)
There are still some issues after this PR where the problems overlap with the follow-up notification system which are fixed there.
Formatting will be done as a tree wide change including upgrading the clang-format version before the release.
Overall the changes greatly improve reliability and maintainability of the library enabling continued maintenance to follow up on smaller issues or introducing new features. The changes are also nicely structured and documented.
Thanks a lot for all the hard work that was put into this!
PR for #579. The layout and rendering was significantly simplified. There are still some feedback loops and iterative renderings, but that should be fixed later with #530.
Note: It still needs some fixes for unit tests