Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic layout #592

Merged
merged 54 commits into from
Aug 8, 2023
Merged

Deterministic layout #592

merged 54 commits into from
Aug 8, 2023

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Jul 21, 2023

PR for #579. The layout and rendering was significantly simplified. There are still some feedback loops and iterative renderings, but that should be fixed later with #530.

Note: It still needs some fixes for unit tests

ennerf added 30 commits June 22, 2023 14:50
(cherry picked from commit a0a03e4)
@ennerf ennerf temporarily deployed to coverage July 22, 2023 07:24 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 07:24 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 80.62% and project coverage change: -0.17 ⚠️

Comparison is base (4b920aa) 51.55% compared to head (096ecd8) 51.38%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #592      +/-   ##
============================================
- Coverage     51.55%   51.38%   -0.17%     
+ Complexity     6438     6413      -25     
============================================
  Files           367      372       +5     
  Lines         37553    37555       +2     
  Branches       6155     6123      -32     
============================================
- Hits          19360    19299      -61     
- Misses        16915    16981      +66     
+ Partials       1278     1275       -3     
Impacted Files Coverage Δ
...t/src/main/java/io/fair_acc/chartfx/axes/Axis.java 100.00% <ø> (ø)
...o/fair_acc/chartfx/axes/spi/ColorGradientAxis.java 0.00% <0.00%> (ø)
.../java/io/fair_acc/chartfx/axes/spi/LinearAxis.java 0.00% <ø> (ø)
.../io/fair_acc/chartfx/axes/spi/LogarithmicAxis.java 0.00% <ø> (ø)
...java/io/fair_acc/chartfx/axes/spi/NumericAxis.java 0.00% <ø> (ø)
...io/fair_acc/chartfx/axes/spi/OscilloscopeAxis.java 76.21% <ø> (ø)
...rtfx/plugins/measurements/DataSetMeasurements.java 75.78% <ø> (+0.01%) ⬆️
...n/java/io/fair_acc/chartfx/ui/ToolBarFlowPane.java 71.42% <50.00%> (ø)
.../fair_acc/chartfx/axes/spi/DefaultNumericAxis.java 68.33% <57.14%> (-3.16%) ⬇️
...c/chartfx/renderer/spi/ContourDataSetRenderer.java 78.70% <70.49%> (+2.66%) ⬆️
... and 15 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ennerf ennerf temporarily deployed to deploy July 22, 2023 07:28 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy July 22, 2023 07:28 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 17:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 17:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 17:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 17:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 22, 2023 17:26 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 70 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ennerf ennerf temporarily deployed to deploy July 22, 2023 17:29 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 24, 2023 04:52 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 24, 2023 04:52 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage July 24, 2023 04:52 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy July 24, 2023 04:56 — with GitHub Actions Inactive
@ennerf ennerf changed the title Deterministic layout [10pt,10pt] Deterministic layout Aug 7, 2023
@wirew0rm wirew0rm changed the title [10pt,10pt] Deterministic layout Deterministic layout Aug 7, 2023
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @ennerf, this greatly reduces the rendering inconsistencies between charts and axes and also reduces the complexity which made it increasingly harder to follow up on issues concerning layout and axes.
The most important improvements are demonstrated in: #579 (comment)

There are still some issues after this PR where the problems overlap with the follow-up notification system which are fixed there.
Formatting will be done as a tree wide change including upgrading the clang-format version before the release.

Overall the changes greatly improve reliability and maintainability of the library enabling continued maintenance to follow up on smaller issues or introducing new features. The changes are also nicely structured and documented.

Thanks a lot for all the hard work that was put into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10pt, 10pt]Restructure layout computations to make rendered output more consistent
2 participants