Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parameters for styling line cap and join #626

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Sep 28, 2023

See #527 (comment) for discussion.

The defaults for

public class Demo extends Application {
	@Override
	public void start(Stage primaryStage) throws Exception {
		XYChart chart = new XYChart();
		DefaultDataSet dataSet = new DefaultDataSet("miter demo",
				new double[]{1, 2, 3},
				new double[]{1, 2, 1},
				3,
				false);
		dataSet.setStyle("-fx-line-width: 6"); // make it more obvious

		BasicDataSetRenderer renderer = new BasicDataSetRenderer(dataSet);
		chart.getRenderers().setAll(renderer);

		chart.getXAxis().setAutoRanging(false);
		chart.getXAxis().setMin(0);
		chart.getXAxis().setMax(100);

		chart.getYAxis().setAutoRanging(false);
		chart.getYAxis().setMin(0);
		chart.getYAxis().setMax(10);

		primaryStage.setScene(new Scene(chart));
		primaryStage.show();
	}
}

now render as

image

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 19 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (380940a) 48.08% compared to head (ab9c2dd) 48.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #626      +/-   ##
============================================
+ Coverage     48.08%   48.10%   +0.02%     
- Complexity     6212     6219       +7     
============================================
  Files           374      374              
  Lines         38288    38285       -3     
  Branches       6105     6105              
============================================
+ Hits          18409    18417       +8     
+ Misses        18729    18721       -8     
+ Partials       1150     1147       -3     
Files Coverage Δ
...acc/chartfx/renderer/spi/ErrorDataSetRenderer.java 59.17% <100.00%> (-0.96%) ⬇️
...acc/chartfx/renderer/spi/ReducingLineRenderer.java 0.00% <0.00%> (ø)
...acc/chartfx/renderer/spi/BasicDataSetRenderer.java 0.00% <0.00%> (ø)
...ir_acc/chartfx/renderer/spi/HistogramRenderer.java 0.00% <0.00%> (ø)
.../fair_acc/chartfx/ui/css/DataSetNodeParameter.java 52.31% <59.09%> (+1.15%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I cannot see any regressions with the samples. Thanks for following it up.

@wirew0rm wirew0rm merged commit 0f6c923 into main Sep 28, 2023
9 of 10 checks passed
@wirew0rm wirew0rm deleted the ennerf/extra-line-params branch September 28, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants