-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Led subsystem and command #48
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes needed, specifically with the way you're setting the pattern in the subsystem. Make sure you're removing all the tuning.json stuff as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple other small changes
Edit:
Also this.animation
is always null, I don't have much experience with CANdles but I doubt that is what is supposed to happen (maybe it is if you just want to set a constant color, if thats the case and we never want to do a pattern animation just set the animation to null and remove this.animation
)
Is this looking better? |
Yea it looks a lot better thanks. One other thing, it doesn't look like you need |
I agree, thats an artifact.
|
The |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we may have to add them back if we want to expand apon this to allow for real animations but this will work for now
No description provided.