Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Led subsystem and command #48

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

SemblanceOfSense
Copy link

No description provided.

Copy link
Contributor

@aaditsangvikar aaditsangvikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes needed, specifically with the way you're setting the pattern in the subsystem. Make sure you're removing all the tuning.json stuff as well.

Copy link
Member

@TotalTaxAmount TotalTaxAmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple other small changes

Edit:
Also this.animation is always null, I don't have much experience with CANdles but I doubt that is what is supposed to happen (maybe it is if you just want to set a constant color, if thats the case and we never want to do a pattern animation just set the animation to null and remove this.animation)

@SemblanceOfSense
Copy link
Author

Is this looking better?

@TotalTaxAmount
Copy link
Member

TotalTaxAmount commented Feb 26, 2025

Yea it looks a lot better thanks. One other thing, it doesn't look like you need currentAnimation, animation, pureRGB, or ledCount (and its constants value) as they are never being read. Other than that it looks good.

@SemblanceOfSense
Copy link
Author

I agree, thats an artifact.

, it doesn't look like you need currentAnimation, animation, pureRGB, or ledCount

@TotalTaxAmount
Copy link
Member

TotalTaxAmount commented Feb 26, 2025

The ledCount (and its constant) is still there, also I just noticed all the this.{r,g,b} variables are also never read

@SemblanceOfSense
Copy link
Author

The ledCount (and its constants) is still there
I had a feeling they might be useful at some point, but I've removed them we can add them back later.

Copy link
Member

@TotalTaxAmount TotalTaxAmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we may have to add them back if we want to expand apon this to allow for real animations but this will work for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants