refactor(falco/app): apply early return pattern in actions code #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgaist
previously approved these changes
Feb 5, 2025
|
LGTM label has been added. Git tree hash: 429a64d5dfb2998d270d4e5845bca5c468e49c58
|
ekoops
force-pushed
the
ekoops/return-early
branch
from
ae6d389 to
8e0d9dc
Compare
sgaist
requested changes
Feb 5, 2025
ekoops
force-pushed
the
ekoops/return-early
branch
from
8e0d9dc to
6645566
Compare
sgaist
requested changes
Feb 5, 2025
ekoops
force-pushed
the
ekoops/return-early
branch
from
6645566 to
331f935
Compare
|
LGTM label has been added. Git tree hash: df3df518696488165bb3a261f1c8bb786c4a6d14
|
Signed-off-by: Leonardo Di Giovanna <[email protected]>
ekoops
force-pushed
the
ekoops/return-early
branch
from
331f935 to
3ebc4fc
Compare
|
/milestone 0.41.0 |
|
LGTM label has been added. Git tree hash: 7a7fee9f31bff564f58e0644cbfc578688126c8a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR simplifies the falco app actions code by applying early return pattern.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: