-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(libsinsp/container_engine): proper containerd support #2195
feat(libsinsp/container_engine): proper containerd support #2195
Conversation
893a76f
to
7c3c360
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2195 +/- ##
==========================================
- Coverage 75.44% 75.06% -0.39%
==========================================
Files 265 267 +2
Lines 34057 34259 +202
Branches 5801 5929 +128
==========================================
+ Hits 25695 25716 +21
- Misses 8362 8543 +181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7c3c360
to
b0e0a90
Compare
b0e0a90
to
bc7d08d
Compare
82b4b68
to
3371202
Compare
2dc0158
to
3978470
Compare
3978470
to
3c6b970
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
…ival Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
…er id Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
8254b52
to
0bc4f0b
Compare
0bc4f0b
to
443f4d8
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
443f4d8
to
513b0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 2e69e549c7a113b3b48e070ce8f554bd85d7e9a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Backport changes from falcosecurity/libs#2195. Signed-off-by: Federico Di Pierro <[email protected]>
Backport changes from falcosecurity/libs#2195. Signed-off-by: Federico Di Pierro <[email protected]>
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Up until now the container information were populated only through the cri api. There are cases in which this is not sufficient (e.g.
bottlerocket
): for example the containerd runtime keeps the containers creates through the cri api separated from the ones created with the containerd api. This PR aims to support also the containers created with the vanilla containerd api.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: