Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): use github-provided arm runners #2236

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 16, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

In the end, i ported our CI to use the shiny new github provided ARM runners: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and mstemm January 16, 2025 09:12
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 16, 2025
@poiana poiana added the size/S label Jan 16, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025

Will add a fake commit on top to trigger drivers ci. Will remove it once the CI passes.

@FedeDP FedeDP changed the title cleanup(ci): use new more powerful github-aarch64-4cpu-16gb arm runner. wip: cleanup(ci): use new more powerful github-aarch64-4cpu-16gb arm runner. Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Perf diff from master - unit tests

     8.60%     +1.30%  [.] sinsp_parser::reset
    10.58%     +0.97%  [.] sinsp::next
     2.59%     +0.57%  [.] sinsp_parser::process_event
     4.56%     -0.34%  [.] gzfile_read
     1.72%     -0.27%  [.] sinsp_evt_filter::sinsp_evt_filter
     1.22%     -0.24%  [.] sinsp_evt::get_syscall_return_value
     5.87%     +0.23%  [.] next_event_from_file
     1.67%     -0.21%  [.] sinsp::fetch_next_event
     3.51%     -0.20%  [.] sinsp_evt::load_params
     0.68%     -0.20%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0117         -0.0117           151           149           151           149
BM_sinsp_split_median                                          -0.0029         -0.0029           151           151           151           151
BM_sinsp_split_stddev                                          +1.2886         +1.2903             2             3             2             3
BM_sinsp_split_cv                                              +1.3158         +1.3175             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0642         -0.0642            60            57            60            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0647         -0.0647            60            57            60            57
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1728         +0.1743             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2533         +0.2549             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0402         +0.0401            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0362         +0.0361            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0364         -0.0362             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0736         -0.0734             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1148         -0.1148            64            57            64            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.1177         -0.1177            65            57            65            57
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.5036         -0.5046             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4393         -0.4403             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0241         +0.0240           382           391           382           391
BM_sinsp_split_container_image_median                          +0.0250         +0.0249           383           392           382           392
BM_sinsp_split_container_image_stddev                          +0.0910         +0.0907             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.0654         +0.0651             0             0             0             0

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (5891ebd) to head (99a1228).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2236      +/-   ##
==========================================
+ Coverage   75.09%   75.11%   +0.02%     
==========================================
  Files         276      276              
  Lines       34391    34394       +3     
  Branches     5927     5922       -5     
==========================================
+ Hits        25826    25836      +10     
+ Misses       8565     8558       -7     
Flag Coverage Δ
libsinsp 75.11% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 16, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@FedeDP FedeDP force-pushed the chore/use_new_arm_runner branch from 7904f90 to 0c64483 Compare January 16, 2025 10:01
@FedeDP FedeDP changed the title wip: cleanup(ci): use new more powerful github-aarch64-4cpu-16gb arm runner. cleanup(ci): use new more powerful github-aarch64-4cpu-16gb arm runner. Jan 16, 2025
leogr
leogr previously approved these changes Jan 16, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025

/hold
a couple of libsinsp_e2e tests are now failing with the new runners.
We don't need this for the release; moving to next milestone.
/milestone 0.21.0

@poiana poiana modified the milestones: 0.20.0, 0.21.0 Jan 16, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025

Also, this superseeds #2200 :) Gonna close that one.

@FedeDP FedeDP force-pushed the chore/use_new_arm_runner branch 4 times, most recently from ad58984 to 2403801 Compare January 17, 2025 08:15
@FedeDP FedeDP force-pushed the chore/use_new_arm_runner branch from 2403801 to 99a1228 Compare January 17, 2025 08:46
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 17, 2025

/milestone 0.20.0

@poiana poiana modified the milestones: 0.21.0, 0.20.0 Jan 17, 2025
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@FedeDP FedeDP changed the title cleanup(ci): use new more powerful github-aarch64-4cpu-16gb arm runner. cleanup(ci): use github-provided arm runners Jan 17, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 17, 2025

/unhold

@poiana poiana merged commit cb93f4b into master Jan 17, 2025
49 checks passed
@poiana poiana deleted the chore/use_new_arm_runner branch January 17, 2025 09:15
@FedeDP FedeDP mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants