Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release/0.20.x #2245

Merged
merged 3 commits into from
Jan 20, 2025
Merged

sync: release/0.20.x #2245

merged 3 commits into from
Jan 20, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 20, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks 3 PRs from master:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 20, 2025

/milestone 0.20.x

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [0.20.0, 0.21.0, TBD, next-driver]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.20.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 20, 2025
Copy link

Perf diff from master - unit tests

     3.37%     +0.74%  [.] sinsp_evt::load_params
     7.63%     +0.44%  [.] sinsp_evt::get_type
     3.87%     +0.37%  [.] gzfile_read
     3.10%     +0.36%  [.] sinsp_thread_manager::get_thread_ref
     1.04%     -0.33%  [.] sinsp_evt::get_param
     5.27%     +0.28%  [.] next_event_from_file
     0.93%     +0.28%  [.] sinsp_evt::get_ts
     2.06%     -0.27%  [.] next
     0.54%     +0.26%  [.] sinsp_fdtable::find
     3.22%     -0.21%  [.] sinsp_thread_manager::find_thread

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0276         -0.0276           151           146           151           146
BM_sinsp_split_median                                          -0.0245         -0.0245           151           147           151           147
BM_sinsp_split_stddev                                          +0.2736         +0.2740             1             2             1             2
BM_sinsp_split_cv                                              +0.3098         +0.3102             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0772         -0.0772            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0782         -0.0782            61            57            61            57
BM_sinsp_concatenate_paths_relative_path_stddev                +0.8002         +0.7999             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.9509         +0.9505             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0493         -0.0493            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0459         -0.0459            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.6350         -0.6351             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6161         -0.6162             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1130         -0.1130            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.1217         -0.1216            63            56            63            56
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.4290         +2.4308             0             2             0             2
BM_sinsp_concatenate_paths_absolute_path_cv                    +2.8660         +2.8679             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0157         -0.0157           395           388           395           388
BM_sinsp_split_container_image_median                          -0.0143         -0.0143           394           388           394           388
BM_sinsp_split_container_image_stddev                          -0.0569         -0.0570             4             4             4             4
BM_sinsp_split_container_image_cv                              -0.0418         -0.0419             0             0             0             0

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.20.x@5a57091). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/0.20.x    #2245   +/-   ##
=================================================
  Coverage                  ?   75.12%           
=================================================
  Files                     ?      276           
  Lines                     ?    34400           
  Branches                  ?     5922           
=================================================
  Hits                      ?    25842           
  Misses                    ?     8558           
  Partials                  ?        0           
Flag Coverage Δ
libsinsp 75.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 22be249 into release/0.20.x Jan 20, 2025
49 checks passed
@poiana poiana deleted the sync/release020x branch January 20, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants