Different mechanism for handling new type #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wbazant You've been on a roll, thank you! The main bug is fixed 🥳 . Would you like to also address the more minor quirk, that Types remains red after adding a new type? 🚀 Or should I make a new issue to address this and the fact that Types is red when the form is first loaded? Loading form: 
Adding a new type: 
Adding an existing type: 
|
|
Sure, it can be fixed on this branch! I've been looking at #534 and you can get the form permanently invalid if you click submit while it's uploading so maybe there's something bigger to do for this form in general. |
|
Actually this fix can go into the main branch, and I'll get to the other bug too, I'm not sure if the fix will be related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514
Thanks Ethan for QAing this thoroughly! I've done something else with redux / callbacks / formik, the previous solution wasn't quite right.