Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When map is panned, geolocation stops centering #568

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

wbazant
Copy link
Collaborator

@wbazant wbazant commented Nov 6, 2024

Closes #518

Copy link
Collaborator

@ezwelty ezwelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbazant The app handles way better, thanks for taking this up.

clicking on the "displaying but not centering" dot re-centers and starts tracking

After panning, at first I expected that it would recenter me when I clicked the track-location button, but instead it stops tracking altogether. Somehow clicking the dot is not as intuitive.

Would it make sense to recenter on first click of the track-location button, and turn off completely if clicked in centering mode? (I think you suggested this single vs double click at some point)

@wbazant
Copy link
Collaborator Author

wbazant commented Nov 10, 2024

@ezwelty thanks for reviewing and for suggesting the change! My original double click suggestion was to switch off then center, but center then switch off is still allowing both of them to happen, and I agree that it makes more sense - if the user loses interest in geolocation after panning they'll probably just ignore it, so if they're interacting with it they probably want to re-center.

The change was easy - the same code as for clicking the dot - so I'll just merge it in.

@wbazant wbazant merged commit 9bb3832 into falling-fruit:main Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve geolocation and position tracking
2 participants