Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#495): Change outdated twitter icon #594

Conversation

ahmedhalac
Copy link
Contributor

@ahmedhalac ahmedhalac commented Nov 14, 2024

Closes #495

Copy link
Collaborator

@ezwelty ezwelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedhalac Thanks! Since we are going through the trouble, I would suggest embracing the X name more since it seems to be here to stay:

  • X-Twitter.svg → X.svg
  • XLogo → X (to match the other social media icon components, if this is a valid component name)
  • Update alt and title text from "Twitter" to "X"

Visually the X logo is less bold than the other social media icons we are using, but this feels like a detail.

@ahmedhalac
Copy link
Contributor Author

I wanted to rename it, but it looks weird to me as just ‘X.’ However, I will make these changes.

Btw I used the same color as the other icons have.

@wbazant wbazant requested a review from ezwelty November 16, 2024 15:30
@wbazant
Copy link
Collaborator

wbazant commented Nov 16, 2024

@ahmedhalac can we add <path stroke="#9b9b9b" stroke-width="0.7" to the .svg? https://stackoverflow.com/a/37687733 told me that this is how one can make an .svg appear thicker, and it seems to work. 0.7 seems more or less right after trying a few values, but if you have a way to do it, you could set the value so it matches exactly the thickness of the instagram icon.

@ahmedhalac
Copy link
Contributor Author

ahmedhalac commented Nov 17, 2024

Looks like this solved bold issue. Thanks @wbazant

Now it looks perfect:

Screenshot 2024-11-17 at 5 03 04 PM

@wbazant wbazant dismissed ezwelty’s stale review November 17, 2024 16:46

Seems addressed now - icon is bold and files renamed, thanks Ahmed!

@wbazant wbazant merged commit 0d8e630 into falling-fruit:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Twitter Icon (Bird Logo) Still Displayed After Rebranding to "X"
3 participants