-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#495): Change outdated twitter icon #594
feat(#495): Change outdated twitter icon #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmedhalac Thanks! Since we are going through the trouble, I would suggest embracing the X name more since it seems to be here to stay:
- X-Twitter.svg → X.svg
- XLogo → X (to match the other social media icon components, if this is a valid component name)
- Update
alt
andtitle
text from "Twitter" to "X"
Visually the X logo is less bold than the other social media icons we are using, but this feels like a detail.
I wanted to rename it, but it looks weird to me as just ‘X.’ However, I will make these changes. Btw I used the same color as the other icons have. |
@ahmedhalac can we add |
Looks like this solved bold issue. Thanks @wbazant Now it looks perfect: |
Seems addressed now - icon is bold and files renamed, thanks Ahmed!
Closes #495