Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix certificate being not trusted on MacOS #76

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mzaniolo
Copy link
Contributor

closes: #35

@mzaniolo mzaniolo requested a review from a team as a code owner October 24, 2024 12:02
@mzaniolo mzaniolo force-pushed the mzaniolo/macos_cert_issue branch 2 times, most recently from bc70312 to ee49bd5 Compare October 24, 2024 12:16
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (a787e25) to head (ed33336).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files           7        7           
  Lines        1352     1352           
=======================================
  Hits         1173     1173           
  Misses        179      179           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a787e25...ed33336. Read the comment docs.

emgrav
emgrav previously approved these changes Oct 24, 2024
Copy link
Member

@emgrav emgrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to have this done, thanks!

.config/starte2e.sh Outdated Show resolved Hide resolved
.config/starte2e.sh Outdated Show resolved Hide resolved
@mzaniolo mzaniolo force-pushed the mzaniolo/macos_cert_issue branch from ee49bd5 to e085065 Compare October 24, 2024 14:39
@mzaniolo mzaniolo force-pushed the mzaniolo/macos_cert_issue branch 5 times, most recently from dd91bf5 to 1ea530d Compare October 31, 2024 14:04
@mzaniolo mzaniolo force-pushed the mzaniolo/macos_cert_issue branch from 1ea530d to ed33336 Compare November 5, 2024 13:19
@mzaniolo mzaniolo merged commit ed33336 into main Nov 5, 2024
5 checks passed
@mzaniolo mzaniolo deleted the mzaniolo/macos_cert_issue branch November 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS tests fail on Mac OS
3 participants