Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow generic attributes to be tracked for changes #29

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

sirewix
Copy link
Contributor

@sirewix sirewix commented Jul 3, 2024

src/config.rs Show resolved Hide resolved
@sirewix sirewix force-pushed the sirewix/add-attrs_to_track branch 3 times, most recently from 47041e2 to ab80194 Compare July 4, 2024 14:36
Copy link

github-actions bot commented Jul 4, 2024

Meow! Coverage

Total: 50.29%

Delta: 1.39%

🐈‍⬛ Untested Changes 🐈‍⬛
File PathLines
src/cache.rs79-81, 118
src/config.rs85-89
src/entry.rs17-22, 24
src/ldap.rs111-114, 116, 120, 151-152

src/cache.rs Show resolved Hide resolved
src/cache.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/entry.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
@sirewix sirewix force-pushed the sirewix/add-attrs_to_track branch 3 times, most recently from 743c9a0 to c5fdeeb Compare July 4, 2024 15:44
Copy link

github-actions bot commented Jul 4, 2024

Meow! Coverage

Total: 53.26%

Delta: 4.36%

🐈‍⬛ Untested Changes 🐈‍⬛
File PathLines
src/cache.rs118, 244, 250
src/config.rs85-89
src/entry.rs17-22, 24
src/ldap.rs111-114, 116, 120, 151-152

src/cache.rs Show resolved Hide resolved
src/cache.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/entry.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
@sirewix sirewix force-pushed the sirewix/add-attrs_to_track branch from c5fdeeb to b3a4361 Compare July 4, 2024 15:49
Copy link

github-actions bot commented Jul 4, 2024

Meow! Coverage

Total: 53.26%

Delta: 4.36%

🐈‍⬛ Untested Changes 🐈‍⬛
File PathLines
src/cache.rs118, 244, 250
src/config.rs85-89
src/entry.rs17-22, 24
src/ldap.rs111-114, 116, 120, 151-152

src/cache.rs Show resolved Hide resolved
src/cache.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/entry.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
@sirewix sirewix marked this pull request as ready for review July 4, 2024 15:52
@sirewix sirewix requested a review from a team as a code owner July 4, 2024 15:53
@sirewix sirewix force-pushed the sirewix/add-attrs_to_track branch from b3a4361 to cc2e8f8 Compare July 4, 2024 17:33
Copy link

github-actions bot commented Jul 4, 2024

Meow! Coverage

Total: 53.26%

Delta: 4.36%

🐈‍⬛ Untested Changes 🐈‍⬛
File PathLines
src/cache.rs118, 244, 250
src/config.rs85-89
src/entry.rs17-22, 24
src/ldap.rs111-114, 116, 120, 151-152, 187-188

src/cache.rs Show resolved Hide resolved
src/cache.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/entry.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
src/ldap.rs Show resolved Hide resolved
Copy link
Contributor

@skomski skomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirewix sirewix merged commit cc2e8f8 into main Jul 5, 2024
1 check passed
@sirewix sirewix deleted the sirewix/add-attrs_to_track branch July 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants