-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Change to native tls #33
Conversation
470c74f
to
8a2ca84
Compare
Meow! CoverageTotal: 52.96%Delta: -0.89% 🐈⬛ Untested Changes 🐈⬛
|
Meow! CoverageTotal: 52.82%Delta: -1.03% 🐈⬛ Untested Changes 🐈⬛
|
To preserve backward-compatability and overall feature richness, I'd suggest to not replace but make 2 features and compile conditionally |
e451ed9
to
4c331d5
Compare
From the API surface we are maintaining backwards compatibility as-is; nothing changes for a user, except that more certificates now work. Well, until |
Need to fix up the tests and add one for client certs, but this seems to work in practice for famedly/famedly-sync#6. |
4c331d5
to
174b1e1
Compare
174b1e1
to
3968adf
Compare
Meow! CoverageTotal: 54.20%Delta: 0.35% 🐈⬛ Untested Changes 🐈⬛
|
4273e1f
to
e55a011
Compare
Meow! CoverageTotal: 54.20%Delta: 0.35% 🐈⬛ Untested Changes 🐈⬛
|
45de7be
to
432c677
Compare
Meow! CoverageTotal: 54.20%Delta: 0.35% 🐈⬛ Untested Changes 🐈⬛
|
Meow! CoverageTotal: 54.20%Delta: 0.35% 🐈⬛ Untested Changes 🐈⬛
|
809f012
to
7a96892
Compare
Somehow these aren't being generated in CI.
7a96892
to
033dd71
Compare
Meow! CoverageTotal: 54.20%Delta: 0.35% 🐈⬛ Untested Changes 🐈⬛
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.