Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle failed to create RTCPeerConnection object error in a call #2011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle failed to create RTCPeerConnection object error in a call #2011

wants to merge 1 commit into from

Conversation

coder-with-a-bushido
Copy link
Contributor

@coder-with-a-bushido coder-with-a-bushido requested a review from a team as a code owner February 2, 2025 04:32
td-famedly
td-famedly reviewed Feb 2, 2025
View reviewed changes
lib/src/voip/call_session.dart
@@ -207,6 +207,9 @@ class CallSession {
// outgoing call
Future<void> initOutboundCall(CallType type) async {
await _preparePeerConnection();
if (pc == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't _preparePeerConnection just rethrow? i.e can you even do anything without a pc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can't do anything without a pc. That's why it's terminating the call with an error code. Do check the createPeerConnection function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@td-famedly td-famedly td-famedly left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coder-with-a-bushido @td-famedly