Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nix flake #13

Merged
merged 3 commits into from
Jul 3, 2024
Merged

feat: nix flake #13

merged 3 commits into from
Jul 3, 2024

Conversation

CherryKitten
Copy link
Member

@CherryKitten CherryKitten commented Jun 18, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link 

* 6ccb04437ee4f5f4709e344d4d66772c18d752f4 feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (6ccb044).

@github-actions GitHub Actions
Copy link 

* 19e182bfe119906182eb80742911b01957ca6f7c feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (19e182b).

@github-actions GitHub Actions
Copy link 

* 6fbb4207695b1d4ae72b35df3e0507feb85a9c3d feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (6fbb420).

@github-actions GitHub Actions
Copy link 

* 21458ee0c63c4abe349c03179c1facd722eacdbf feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (21458ee).

@github-actions GitHub Actions
Copy link 

* 8595fe0ed8ee5ddf77f22c37cb81212dd26833c8 feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (8595fe0).

jcgruenhage
jcgruenhage previously requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, found something that was never mentioned but is required: ssss is not available, but is required.

@github-actions GitHub Actions
Copy link 

* 98889d5af2a7f56e899fd4d30e5b1abcdecb8d63 feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (98889d5).

@CherryKitten CherryKitten marked this pull request as ready for review June 26, 2024 12:24
@github-actions GitHub Actions
Copy link 

* 38572a137fef4dade9e08f3c788363e61fac2db8 feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

The pull request's base (74e9d4f) authenticates the pull request's head (38572a1).

@lrsksr lrsksr self-requested a review June 27, 2024 09:07
@lrsksr
Copy link
Contributor

lrsksr commented Jun 28, 2024

I don't know if that's a deliberate choice but I wasn't able to generate PGP keys with the fos-new script because the openpgp-ca package didn't include the patches that are mentioned in the Readme.

@CherryKitten
Copy link
Member Author

I don't know if that's a deliberate choice but I wasn't able to generate PGP keys with the fos-new script because the openpgp-ca package didn't include the patches that are mentioned in the Readme.

nope, that's actually something i forgot to do, i wanted to add the patches into the flake as soon as the package is upstream

I'll do that on monday

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 

* 5e1bde0e7b2ac7fbb2eb80a92829802b72ab36d5 feat(fos-partitions): add another partition id
|   - Error: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live
* 9b3da9d9aa470a38d4f348b4e3154f003a5aa6d5 feat: nix flake
|   - Error: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

Failed to authenticate commits.

Error: 2 errors occurred while verifying the commits.  2 commits couldn't be authenticated.  Note: not all errors are fatal.  The first error is shown:

Caused by:
    0: Could not verify commits 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0..5e1bde0e7b2ac7fbb2eb80a92829802b72ab36d5
    1: While verifying commit 5e1bde0e7b2ac7fbb2eb80a92829802b72ab36d5
    2: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 

* 31bfe3ab31ad1bb249efbeb107996a1dd45e7e25 chore: update sammy's PGP key in openpgp-policy
|   - Error: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live
* 5e1bde0e7b2ac7fbb2eb80a92829802b72ab36d5 feat(fos-partitions): add another partition id
|   - Error: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live
* 9b3da9d9aa470a38d4f348b4e3154f003a5aa6d5 feat: nix flake
|   - Error: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live
* 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0 chore: remove duplicate stick check from fos-partitions and fos-working-directory
    - Trust root.

Failed to authenticate commits.

Error: 3 errors occurred while verifying the commits.  3 commits couldn't be authenticated.  Note: not all errors are fatal.  The first error is shown:

Caused by:
    0: Could not verify commits 74e9d4f3f9b75dae06b26148304b4ed03d99d0a0..31bfe3ab31ad1bb249efbeb107996a1dd45e7e25
    1: While verifying commit 31bfe3ab31ad1bb249efbeb107996a1dd45e7e25
    2: Key `65CACC1553107A22B5CDD696BF4B5516695A5D16` is bad: The primary key is not live

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 

* d8ee509eee8cf461fe8f13338ad2c26ff25bb072 feat(fos-partitions): add another partition id
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 6ec9389078c3f930b1b8dbc2ec76d9a74f30c15b feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 8c663ecabba2ad7258672acabefae2412623f5bf chore: update sammy's PGP key in openpgp-policy
    - Trust root.

The pull request's base (8c663ec) authenticates the pull request's head (d8ee509).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 

* 2d4d9645ef19732dbc175c7a707434e3cbe54b88 feat(fos-mount): use mkdir -p
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* fa5b52f31f8fa509ce76afcd69a2a45b90f15d86 feat(fos-partitions): add another partition id
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* f58dde7a0228692b41a3c0b5c729bbb141e98b6b feat: nix flake
|   - Authorized by Sammy <[email protected]> [BF4B5516695A5D16]
* 8c663ecabba2ad7258672acabefae2412623f5bf chore: update sammy's PGP key in openpgp-policy
    - Trust root.

The pull request's base (8c663ec) authenticates the pull request's head (2d4d964).

@CherryKitten
Copy link
Member Author

/fast-forward

@github-actions github-actions bot merged commit 2d4d964 into main Jul 3, 2024
2 checks passed
@github-actions github-actions bot deleted the sammy/nix branch July 3, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrsksr lrsksr lrsksr approved these changes

@jcgruenhage jcgruenhage jcgruenhage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CherryKitten @lrsksr @jcgruenhage