fix(DiskIO, PhysicalDisk): fix readlink

fastfetch-cli · Dec 18, 2023 · 70160d3 · 70160d3
1 parent 600f6c7
commit 70160d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/detection/diskio/diskio_linux.c b/src/detection/diskio/diskio_linux.c
@@ -23,8 +23,11 @@ const char* ffDiskIOGetIoCounters(FFlist* result, FFDiskIOOptions* options)
         char pathSysBlock[PATH_MAX];
         snprintf(pathSysBlock, PATH_MAX, "/sys/block/%s", devName);
 
-        char pathSysDeviceReal[PATH_MAX] = "";
-        readlink(pathSysBlock, pathSysDeviceReal, sizeof(pathSysDeviceReal) - 1);
+        char pathSysDeviceReal[PATH_MAX];
+        ssize_t pathLength = readlink(pathSysBlock, pathSysDeviceReal, sizeof(pathSysDeviceReal) - 1);
+        if (pathLength < 0)
+            continue;
+        pathSysDeviceReal[pathLength] = '\0';
 
         if (strstr(pathSysDeviceReal, "/virtual/")) // virtual device
             continue;

diff --git a/src/detection/physicaldisk/physicaldisk_linux.c b/src/detection/physicaldisk/physicaldisk_linux.c
@@ -23,8 +23,11 @@ const char* ffDetectPhysicalDisk(FFlist* result, FFPhysicalDiskOptions* options)
         char pathSysBlock[PATH_MAX];
         snprintf(pathSysBlock, PATH_MAX, "/sys/block/%s", devName);
 
-        char pathSysDeviceReal[PATH_MAX] = "";
-        readlink(pathSysBlock, pathSysDeviceReal, sizeof(pathSysDeviceReal) - 1);
+        char pathSysDeviceReal[PATH_MAX];
+        ssize_t pathLength = readlink(pathSysBlock, pathSysDeviceReal, sizeof(pathSysDeviceReal) - 1);
+        if (pathLength < 0)
+            continue;
+        pathSysDeviceReal[pathLength] = '\0';
 
         if (strstr(pathSysDeviceReal, "/virtual/")) // virtual device
             continue;