Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #663

Closed
wants to merge 3 commits into from
Closed

Minor fixes #663

wants to merge 3 commits into from

Conversation

apocelipes
Copy link
Contributor

  • fix ffPathExists: only using stat makes FF_PATHTYPE_LINK never work under *nix systems. Some symlinks are linked to directories, so keep use stat when FF_PATHTYPE_LINK is not contained in type paramater for backward compatibility.
  • ffWriteFileData only retries when error is ENOENT. Other errors such as EACCESS, ELOOP or EDQUOT also fail mkdir(), retrying after these errors is useless.
  • fix readlink usage: readlink won't append a NUL, we should check the return value and add a NUL handly.

@CarterLi CarterLi closed this in 11b1b97 Dec 18, 2023
@apocelipes
Copy link
Contributor Author

Would you tell why close this?

I think readlink's call is actually a bug.

@CarterLi
Copy link
Member

See 4ae0c43

@CarterLi CarterLi mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants