fix: fix trailing space #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apocelipes
force-pushed
the
fix-trailing-space
branch
from
c70a3ee to
0bc9a04
Compare
apocelipes
force-pushed
the
fix-trailing-space
branch
from
0bc9a04 to
1f7ab44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked all calls of ffAppendFDBuffer and fix most of the trailing space problems.
Some data just passed to the parser(e.g. strtoul), trailing space in these cases are not problems, stay as is.
The contents of some sysfs files have a fixed format(like /sys/class/net/*/operstate), so instead of removing trailing spaces and newlines, the contents being compared are updated.
Code under
src/logoI didn't change because there is no trailing space problem here, but I'm not 100% sure. This shoule be checked in reviewing.