fix: static content for routePrefix with subpath (#165) #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #165, where having a subpath in
routePrefix
breaks static content loading due to changes in #164.Now the static content urls are relative only with a trailing slash, otherwise they're absolute - meaning they work the same as before the regression.
The tests for this were already developed but with wrong assertions, to be able to test static content is loaded I assume we'd need to run playwright with different prefix variations, which would require a refactor as all playwright tests are run with
/documentation
as the prefix.Please let me know if you have any suggestions regarding the tests.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct