Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quote the ${WEIGHT_DIR} to handle special characters #1091

Merged
merged 1 commit into from
Oct 24, 2024
Merged

quote the ${WEIGHT_DIR} to handle special characters #1091

merged 1 commit into from
Oct 24, 2024

Conversation

jmitrevs
Copy link
Contributor

Description

The main branch pytests fail in cases where the paths have special characters. This fixes the problem.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

In the current main branch, 20 of the test_activations.py tests fail, since they produce paths with parentheses. This PR fixes the problem.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the bug label Oct 24, 2024
@JanFSchulte JanFSchulte merged commit 03096cf into main Oct 24, 2024
6 of 9 checks passed
@JanFSchulte JanFSchulte deleted the path_special_char_esc branch October 24, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanFSchulte JanFSchulte JanFSchulte approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmitrevs @JanFSchulte