Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add bundle_report compatibility --ruby-version report #116

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[FEATURE] Add bundle_report compatibility --ruby-version report #116

merged 2 commits into from
Sep 9, 2024

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented May 18, 2024 •
edited
Loading

Description

Closes #115
Closes #17

Motivation and Context

Have an easy way to get the incompatible gems with a given ruby version.

How Has This Been Tested?

Wrote some automated tests and Installed the gem locally

Screenshots:

Peek 2024-05-19 22-48

I will abide by the code of conduct

@JuanVqz JuanVqz force-pushed the bundle-report-compability-ruby-version branch 5 times, most recently from 9270be1 to 849316b Compare May 20, 2024 04:14
@JuanVqz JuanVqz changed the title [WIP] Add bundle_report compatibility --ruby-version report [FEATURE] Add bundle_report compatibility --ruby-version report May 20, 2024
@JuanVqz JuanVqz force-pushed the bundle-report-compability-ruby-version branch 4 times, most recently from eb3306c to 05fa22e Compare May 20, 2024 04:45
@JuanVqz JuanVqz requested review from etagwerker, arielj, fbuys and rishijain and removed request for fbuys May 20, 2024 04:50
@JuanVqz JuanVqz marked this pull request as ready for review May 20, 2024 04:53
@JuanVqz JuanVqz force-pushed the bundle-report-compability-ruby-version branch from 05fa22e to a0fb85c Compare May 20, 2024 04:58
@JuanVqz JuanVqz force-pushed the bundle-report-compability-ruby-version branch 4 times, most recently from a3b1cf5 to 2d7e904 Compare June 6, 2024 16:35
julioalucero
julioalucero approved these changes Jul 22, 2024
View reviewed changes
Copy link

@julioalucero julioalucero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and It looks good! Added just minor comments 🚀 !!

Also, not for this PR, but now that you added lib/next_rails/bundle_report/ruby_version_compatibility.rb maybe worth moving rails logic to lib/next_rails/bundle_report/rails_version_compatibility.rb and have a kind of "strategy pattern" or something similar at #compatibility that call one or other.

p.s.: Remember to increase the version.

lib/next_rails/bundle_report/ruby_version_compatibility.rb Outdated Show resolved Hide resolved
lib/next_rails/bundle_report/ruby_version_compatibility.rb Outdated Show resolved Hide resolved
@JuanVqz
[FEATURE] Support compatibility for Ruby versions
41531e8 
the `bundle_report compatibility` now supports the `--ruby-version` flag
to ask it for incompatible gems with the given Ruby version.

Closes #17
Closes #115
@JuanVqz JuanVqz force-pushed the bundle-report-compability-ruby-version branch from 2d7e904 to 41531e8 Compare July 31, 2024 19:32
@JuanVqz
Copy link
Member Author

JuanVqz commented Jul 31, 2024 •
edited
Loading

I tested and It looks good! Added just minor comments 🚀 !!

Also, not for this PR, but now that you added lib/next_rails/bundle_report/ruby_version_compatibility.rb maybe worth moving rails logic to lib/next_rails/bundle_report/rails_version_compatibility.rb and have a kind of "strategy pattern" or something similar at #compatibility that call one or other.

Yeah! that's a great suggestion, looking forward to doing it next...

p.s.: Remember to increase the version.

Not for this PR, we can bump the version o a specific PR

@JuanVqz
Copy link
Member Author

JuanVqz commented Jul 31, 2024

@etagwerker or @rishijain can you please merge this PR? Julio already tested it :shipit: Thanks!

etagwerker
etagwerker approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanVqz @julioalucero Sorry for the delay. Thank you!

@etagwerker etagwerker merged commit cb7e090 into main Sep 9, 2024
0 of 11 checks passed
@etagwerker etagwerker deleted the bundle-report-compability-ruby-version branch September 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julioalucero julioalucero julioalucero approved these changes

@etagwerker etagwerker etagwerker approved these changes

@arielj arielj Awaiting requested review from arielj

@rishijain rishijain Awaiting requested review from rishijain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JuanVqz @etagwerker @julioalucero