Use Rainbow to remove GPL dependency Colorize #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlkelly
changed the title
|
@etagwerker, Do you have any thoughts about this change regarding the licensing? |
|
Ah. It looks like If we use Rainbow version 2 doesn't include the String refinement, which means it's no longer a drop-in replacement. The code would need to be updated to use the |
I don't think this is imperative. I'm fine with supporting Ruby 2.6 and higher. |
etagwerker
approved these changes
Sep 9, 2024
JuanVqz
added a commit
that referenced
this pull request
Sep 22, 2024
Pull Request #120 removed Colorize in favor of Rainbow, `bundle_report/ruby_version_compatibility.rb` was using Colorize and we need to update it to use Rainbow
JuanVqz
added a commit
that referenced
this pull request
Sep 22, 2024
Pull Request #120 removed Colorize in favor of Rainbow, `bundle_report/ruby_version_compatibility.rb` was using Colorize and we need to update it to use Rainbow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Colorize dependency uses the GPL 2.0 license. This work switches the dependency to Rainbow, which uses the MIT license, ensuring that NextRails also does not inherit the GPL license.
Motivation and Context
Some organizations are not allowed to use the GPL license. Switching to Rainbow allows others to use NextRails because it will no longer include a GPL dependency.
How Has This Been Tested?
The change is relatively minimal, and Rainbow has a similar API to Colorize, albeit using Ruby Refinements.
Screenshots:
I will abide by the code of conduct