Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rainbow change): the methods (bold & white) are not on String but… #132

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mmotherwell
Copy link

… Rainbow

Description

Bug from the change from colorize gem to Rainbow.

Motivation and Context

I got this method running bundle_report outdated

```undefined method `bold' for an instance of String (NoMethodError)

      #{Rainbow(header.bold.white)}: released #{gem.age} (latest version, #{gem.latest_version.version}, released #{gem.latest_version.age})```

How Has This Been Tested?

Ran the test suite. Used the gem in my own gemfil.

Screenshots:

It's a small change.

I will abide by the code of conduct

Copy link

@taylorrf taylorrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the same error using next_rails-1.4.1 and ruby 3.3.4 and the code change proposed here fixed it for me locally. Thank you @mmotherwell

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 💯

@etagwerker etagwerker merged commit e9d2345 into fastruby:main Oct 25, 2024
6 checks passed
@etagwerker
Copy link
Member

@taylorrf @mmotherwell Just released https://rubygems.org/gems/next_rails/versions/1.4.2 with this patch. Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants