Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROAD-607: Action Plan should only include approved stories #322

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Jan 22, 2024

Jira Ticket

Closes #321

Motivation / Context

Action Plan should only include Approved stories

QA / Testing Instructions

Visit the action plan page and should only include Approved stories

Screenshots:


I will abide by the code of conduct.

@JuanVqz JuanVqz requested a review from fbuys January 22, 2024 22:07
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tasks with approved, pending, and rejected.

@JuanVqz JuanVqz changed the title Action Plan should only include approved stories CVT-1 Action Plan should only include approved stories Jan 23, 2024
@JuanVqz JuanVqz force-pushed the action-plan-should-only-include-approved-stories branch from 9103f3b to 3e585ba Compare January 23, 2024 17:12
@fbuys fbuys changed the title CVT-1 Action Plan should only include approved stories VLT-1: Action Plan should only include approved stories Jan 23, 2024
@fbuys fbuys changed the title VLT-1: Action Plan should only include approved stories ROAD-607: Action Plan should only include approved stories Jan 23, 2024
@fbuys fbuys force-pushed the action-plan-should-only-include-approved-stories branch from 83f2d27 to 597d0c9 Compare January 23, 2024 17:58
Copy link
Contributor

@hmdros hmdros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbuys @JuanVqz
the one question I have from QAing this is: does locking the project/subproject should change that scoped query?

Right now if I lock the subproject it doesn't affect the outcome of the ActionPlan, should we consider it?
If we don't want to consider it, this should be good to go.

@fbuys fbuys merged commit 7b52e9f into main Jan 23, 2024
3 checks passed
@fbuys fbuys deleted the action-plan-should-only-include-approved-stories branch January 23, 2024 18:28
@fbuys
Copy link
Contributor

fbuys commented Jan 23, 2024

@fbuys @JuanVqz the one question I have from QAing this is: does locking the project/subproject should change that scoped query?

Right now if I lock the subproject it doesn't affect the outcome of the ActionPlan, should we consider it? If we don't want to consider it, this should be good to go.

The locking feature does not affect the action plan export at all.

@hmdros
Copy link
Contributor

hmdros commented Jan 23, 2024

@fbuys @JuanVqz the one question I have from QAing this is: does locking the project/subproject should change that scoped query?

Right now if I lock the subproject it doesn't affect the outcome of the ActionPlan, should we consider it? If we don't want to consider it, this should be good to go.

Locking a project is usually used to not update project's information. It shouldn't affect the status on stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action Plan should only include approved stories
3 participants