-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error modeling to CADET-Process #187
Draft
schmoelder
wants to merge
95
commits into
dev
Choose a base branch
from
error_modeling
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were two interfaces in the `OptimizationProblem` for calling evaluation functions (e.g. objectives): one for evaluating individuals, and one for populations. To simplify the code base, these two methods were now unified. To ensure backward compatibility, a 1D-Array is returned if a single individual is passed to the function.
Co-authored-by: r.jaepel <[email protected]>
Previously, the cadet path set in Cadet(install_path="path") was not inherited into cadet instances created from the run() method.
Fix and extend tests about .calculate_interstitial_rt/velocity
Previously, this was required because CADET-Core was not setting the PATH correctly. Now, this can lead to inconsistent behaviour. Note, this requires CADET>4.4.0
Recently, the option to (not) plot the time axis using minutes was introduced. This commit fixes some methods that were not properly implemented. Moreover, the name of the flag was changed from `use_minutes` to `x_axis_in_minutes` to make clear that only plotting is affected and not other parameter values (e.g. start and end times).
Co-authored-by: daklauss <[email protected]>
Updates and Fixes plot_at_position by adding start, end and x_axis_in_minutes as parameters in solution.py
A typo in the paramameters list lead to an issue when querying the optimizer options.
…hon. Fix Cadet.get_cadet_version() Fix create_lwe method of CadetAdapter
With the Miniforge 23.3.1 release, the Miniforge and Mambaforge installers became essentially identical. The only difference between the two was their name and, subsequently, the default installation directory. For more information, see https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/
Forgot to remove this file when migrating to `pyproject.toml`.
…ation Warning Co-authored-by: r.jaepel <[email protected]>
The CITATION.bib file serves as an collection of papers that we like to have cited when CADET-Process is used. Further, it is recognized by Github and added to the sidebar of the repo.
9a4caf8
to
9621814
Compare
9621814
to
cb8757e
Compare
35e0c67
to
d97cf31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic functionality for error modeling in CADET-Process.
This includes providing different error distributions to
Process
objects, e.g. to model fluctuations in pump flow rate, valve switching delays, variations in concentrations etc.Moreover, a
Variator
class should handle the registration / connection between the individual distributions and the actual parameters of the model (i.e.Process
).To do
Events
orOptimizationVariable
)DistributionBase
in parameter estimation routines (i.e. the parameters of the distribution need to be exposed somehow)Process
but simulation output (e.g. sensor noise?)Demo
Here is a little snippet how different distributions could be used