Upgrade metacolon dependency #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FND
commented
Jan 30, 2025
| @@ -1,5 +1,5 @@ | |||
| let { repr } = require("faucet-pipeline-core/lib/util"); | |||
| let colonParse = require("metacolon"); | |||
| let metacolon = import("metacolon"); | |||
There was a problem hiding this comment.
requireing ESM requires Node v22, so we'll have to do this little dance...
| @@ -19,19 +19,21 @@ module.exports = class Page { | |||
| return Promise.resolve(this); | |||
| } | |||
|
|
|||
| let { headers, body } = await colonParse(this.sourcePath); | |||
| let { colonParse } = await metacolon; | |||
There was a problem hiding this comment.
... but apparently Node v18 doesn't do top-level await yet? I thought it should, but GitHub Actions disagreed. 🤷
FND
force-pushed
the
metacupgrade
branch
2 times, most recently
from
640729c to
c88546c
Compare
|
Woha, that's a nice workaround. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the minor frenzy of #99, I believe I've figured it out after all: metacolon v2 should be good to go now.