Convert to Bridgetown #93
Conversation
moonglum
force-pushed
the
bridgetown
branch
6 times, most recently
from
52f3f79 to
9a25dfb
Compare
| @@ -0,0 +1,109 @@ | |||
| --- | |||
| layout: default | |||
| title: "Impressum" | |||
There was a problem hiding this comment.
New file, this is a copy from my homepage
|
@FND This is the switch to bridgetown I did over the winter break (first commit). The second commit is what we discussed today. Feedback welcome! |
There was a problem hiding this comment.
Looks good to me - I think? It's a bit much to review 😅 , but I understand why that's inevitable.
I'm a bit wary of Ruby increasing the maintenance burden (techno mix and barrier to entry), but that's mostly a theoretical concern at this point: Your optimization here is perfectly understandable.
Anyway, thanks for doing this!
I could not get the setup to work
Not quite sure what this means or implies...
|
|
||
| &:focus { | ||
| .skip:focus { |
There was a problem hiding this comment.
If you're using PostCSS and esbuild anyway, why not have either convert nested CSS during deployment?
There was a problem hiding this comment.
Good point, I will take a look
That I invested an hour to get our old setup to work, but after everything exploded in my face multiple times, I gave up, copied my homepage, replaced the content and CSS, and was ready to go 😂 |
I could not get the setup to work, so I instead copied the setup from my homepage. This also updates some parts of the content (mainly legal stuff) and cleans up the CSS and JS.
|
Merged and deployed ✔️ |
I could not get the setup to work, so I instead copied the setup from my homepage. This also updates some parts of the content (mainly legal stuff) and cleans up the CSS (also went from SCSS to CSS) and JS. Also uses Bridgetown Components.